Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated PF dropdown with latest version #1241

Closed
gitdallas opened this issue Aug 1, 2023 · 6 comments · Fixed by #1375
Closed

Replace deprecated PF dropdown with latest version #1241

gitdallas opened this issue Aug 1, 2023 · 6 comments · Fixed by #1375
Assignees
@gitdallas

Comments

@gitdallas
Copy link
Collaborator

gitdallas commented Aug 1, 2023 •
edited
Loading

Will require some refactoring. Several use cases of Dropdown, DropdownItem, DropdownGroup, DropdownToggle KebabToggle, DropdownToggleCheckbox

https://www.patternfly.org/components/menus/dropdown
@gitdallas gitdallas self-assigned this Aug 1, 2023
@mturley
Copy link
Collaborator

mturley commented Aug 9, 2023 •
edited
Loading

@gitdallas Note: I did this in KebabDropdown in #1126 and then had to revert it in #1150. Might be able to start by just reverting that revert (and then making sure isAriaDisabled is still used where needed instead of isDisabled).

@gildub
Copy link
Contributor

gildub commented Aug 9, 2023

@gitdallas, @mturley,
I don't see the value to have tackle equivalent of KebabDropdown and if we do it might just make things more complicated to understand, sort of unnecessary complexity.
What do you guys think ?

@gitdallas
Copy link
Collaborator Author

gitdallas commented Aug 9, 2023 •
edited
Loading

@gildub - it looks like kebab dropdown is used often, so it would reduce some duplicated code.
image

turley's pr appears to be doing it the same way as PF's example https://www.patternfly.org/components/menus/dropdown#with-kebab-toggle

@mturley
Copy link
Collaborator

mturley commented Aug 9, 2023

Yeah I think this may be a case where the PF component is more verbose now for the sake of composability, but that introduces a bunch of repetition if we don't abstract it into our own component. Personally I think it's a good compromise: we can still keep things in our components clean and terse, but we have flexibility to adjust the structure in the future without needing PF changes.

@gitdallas
Copy link
Collaborator Author

@gildub - were you still planning to work on this one?

@gitdallas
Copy link
Collaborator Author

i've started now

@gitdallas gitdallas mentioned this issue Sep 19, 2023
Merged
gitdallas added a commit that referenced this issue Sep 26, 2023
@gitdallas
🌱 1241 replace deprecated pf dropdown (#1375)
5fbe7b6 
removed all instances of deprecated dropdown related imports (dropdown,
dropdownItem, dropdownGroup, dropdownToggle, etc)

closes #1241

---------

Signed-off-by: gitdallas <dallas.nicol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitdallas gitdallas

Labels
None yet
Projects
Planning
Status: ✅ Done
Konveyor UI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 1241 replace deprecated pf dropdown gitdallas/tackle2-ui
3 participants
@mturley @gildub @gitdallas