From 3d72ff905997ae7f18682748594d8d8680a827c8 Mon Sep 17 00:00:00 2001
From: Ian Bolton <ibolton@redhat.com>
Date: Tue, 8 Aug 2023 23:26:43 +0000
Subject: [PATCH] :bug: Reset wizard form after analysis run (#1267)

- Resolves #1256
- When closing the wizard, the taskgroup state hangs around between
analysis runs causing problems. This PR cleans up the react state when
closing/submitting the analysis wizard

Signed-off-by: ibolton336 <ibolton@redhat.com>
---
 .../analysis-wizard/analysis-wizard.tsx       | 32 ++++++++++---------
 1 file changed, 17 insertions(+), 15 deletions(-)

diff --git a/client/src/app/pages/applications/analysis-wizard/analysis-wizard.tsx b/client/src/app/pages/applications/analysis-wizard/analysis-wizard.tsx
index 696a2ab44..e57226f6d 100644
--- a/client/src/app/pages/applications/analysis-wizard/analysis-wizard.tsx
+++ b/client/src/app/pages/applications/analysis-wizard/analysis-wizard.tsx
@@ -102,12 +102,6 @@ export const AnalysisWizard: React.FC<IAnalysisWizard> = ({
   const [stepIdReached, setStepIdReached] = React.useState(1);
   const isMutating = useIsMutating();
 
-  React.useEffect(() => {
-    if (!currentTaskgroup) {
-      createTaskgroup(defaultTaskgroup);
-    }
-  }, []);
-
   const onCreateTaskgroupSuccess = (data: Taskgroup) => {
     setCurrentTaskgroup(data);
   };
@@ -287,12 +281,22 @@ export const AnalysisWizard: React.FC<IAnalysisWizard> = ({
 
   const isModeValid = applications.every((app) => isModeSupported(app, mode));
 
+  const handleCancel = () => {
+    if (currentTaskgroup && currentTaskgroup.id) {
+      deleteTaskgroup(currentTaskgroup.id);
+    }
+    setCurrentTaskgroup(null);
+    reset();
+    onClose();
+  };
+
   const onSubmit = (fieldValues: AnalysisWizardFormValues) => {
     if (currentTaskgroup) {
       const taskgroup = setupTaskgroup(currentTaskgroup, fieldValues);
-
       submitTaskgroup(taskgroup);
     }
+    setCurrentTaskgroup(null);
+    reset();
     onClose();
   };
 
@@ -301,13 +305,11 @@ export const AnalysisWizard: React.FC<IAnalysisWizard> = ({
     { prevId, prevName }
   ) => {
     if (id && stepIdReached < (id as number)) setStepIdReached(id as number);
-  };
-
-  const handleClose = () => {
-    reset();
-    if (currentTaskgroup && currentTaskgroup.id)
-      deleteTaskgroup(currentTaskgroup.id);
-    onClose();
+    if (id === StepId.SetTargets) {
+      if (!currentTaskgroup) {
+        createTaskgroup(defaultTaskgroup);
+      }
+    }
   };
 
   const analyzableApplications = useAnalyzableApplications(applications, mode);
@@ -410,7 +412,7 @@ export const AnalysisWizard: React.FC<IAnalysisWizard> = ({
             onBack={onMove}
             onSave={handleSubmit(onSubmit)}
             onClose={() => {
-              handleClose();
+              handleCancel();
             }}
           />
         </FormProvider>