✨ Add /tasks patch; return 202 for task actions and updates. #660
Conversation
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
| const ( | ||
| LocatorParam = "locator" | ||
| ) | ||
|
|
There was a problem hiding this comment.
hint: LocatorParam unused. The /tasks now supports filtering.
api/task.go
Outdated
| @@ -55,10 +51,11 @@ func (h TaskHandler) AddRoutes(e *gin.Engine) { | |||
| routeGroup.POST(TasksRoot, h.Create) | |||
| routeGroup.GET(TaskRoot, h.Get) | |||
| routeGroup.PUT(TaskRoot, h.Update) | |||
| routeGroup.PATCH(TaskRoot, Transaction, h.Patch) | |||
| routeGroup.DELETE(TaskRoot, h.Delete) | ||
| routeGroup.GET(TasksReportQueueRoot, h.Queued) | ||
| // Actions | ||
| routeGroup.PUT(TaskSubmitRoot, h.Submit, h.Update) | ||
| routeGroup.PUT(TaskSubmitRoot, Transaction, h.Submit) |
There was a problem hiding this comment.
hint: with complexity delegated to the task manager, simpler to implement submit as a patch and no longer chain submit; state=Ready; update().
BaseHandler.modBody() should probably go away.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
| } | ||
|
|
||
| // Submit godoc | ||
| // @summary Submit a task. | ||
| // @description Submit a task. | ||
| // @description Patch and submit a task. |
There was a problem hiding this comment.
hint: Much better for the caller to be able to patch a task when submitting rather than update. This will support submit with minimal or no patch.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
| ctx.Request.Body = io.NopCloser(bfr) | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
hint: removed in favor of simpler, more direct approach.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
task/manager.go
Outdated
| @@ -188,23 +188,19 @@ func (m *Manager) Update(db *gorm.DB, requested *Task) (err error) { | |||
| task.TTL = requested.TTL | |||
| task.Data = requested.Data | |||
| task.ApplicationID = requested.ApplicationID | |||
| task.BucketID = requested.BucketID | |||
There was a problem hiding this comment.
hint: fixes taskgroup bucket propagation broken in multi-provider pr.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
| @@ -150,6 +150,7 @@ func (m *Manager) Create(db *gorm.DB, requested *Task) (err error) { | |||
| task.TTL = requested.TTL | |||
| task.Data = requested.Data | |||
| task.ApplicationID = requested.ApplicationID | |||
| task.BucketID = requested.BucketID | |||
There was a problem hiding this comment.
hint: fixes task group bucket propagation. ^ broken by earlier multi-provider PR.
noticed while regression testing.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Adds patch endpoints for:
The Update() methods on both Task and Taskgroup support both PUT and PATCH depending on the http method. They also support delegation from Submit() which mainly sets the state=Ready.
Updated to return 202 (accepted) on success.
BaseHandler.modBody() removed.
Add patch support to binding client.
Adds API test for task patch.
closes: #661
closes: #662