Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ import global ci workflow #418

Merged
merged 1 commit into from
Aug 28, 2023
Merged

✨ import global ci workflow #418

merged 1 commit into from
Aug 28, 2023

Conversation

fabianvf
Copy link
Contributor

@fabianvf fabianvf commented Jun 22, 2023

This will import the global CI workflow, which runs the end to end tests defined in https://github.com/konveyor/go-konveyor-tests (for now, it will be expanded to more suites as they become quick and stable enough). This helps to ensure that individual components aren't breaking the project as a whole, which should help to smooth out the release process.

@fabianvf fabianvf changed the title import global ci workflow ✨ import global ci workflow Jun 22, 2023
@fabianvf
Copy link
Contributor Author

we could also change the test-e2e job to this, since the global-ci will install minikube/tackle as part of its run:

  test-e2e:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3

      - name: Build and save image
        run: |
          make docker-build
          docker save -o /tmp/tackle2-hub.tar quay.io/konveyor/tackle2-hub:latest

      - name: Upload image as artifact
        uses: actions/upload-artifact@v3
        with:
          name: tackle2-hub
          path: /tmp/tackle2-hub.tar
          retention-days: 1

Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
aufi added a commit to aufi/tackle2-hub that referenced this pull request Jun 23, 2023
Integration E2E tests using API are now in https://github.com/konveyor/go-konveyor-tests
those are executed using global CI workflows.

Related to:
- konveyor#310
- konveyor#418

Signed-off-by: Marek Aufart <maufart@redhat.com>
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel
Copy link
Contributor

jortel commented Jun 23, 2023

@fabianvf Can you add a brief description about what this will do?

aufi added a commit that referenced this pull request Jun 30, 2023
Integration E2E tests using API are now in
https://github.com/konveyor/go-konveyor-tests those are executed using
global CI workflows.

Related to:
- #310
- #418

Signed-off-by: Marek Aufart <maufart@redhat.com>
@jortel jortel merged commit 6a361d0 into konveyor:main Aug 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants