Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate duplicate analysis dependencies. #572

Closed
jortel opened this issue Dec 5, 2023 · 0 comments · Fixed by #573
Closed

Tolerate duplicate analysis dependencies. #572

jortel opened this issue Dec 5, 2023 · 0 comments · Fixed by #573
Assignees
@jortel
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jortel
Copy link
Contributor

jortel commented Dec 5, 2023

Reported analysis dependencies my contain duplicates. This needs to be tolerated.
Some use cases:

  • The same dependency reported on an analysis as both direct and indirect.
  • The same dependency reported as indirect by multiple dependencies (transient).
@jortel jortel added the kind/bug Categorizes issue or PR as related to a bug. label Dec 5, 2023
@jortel jortel self-assigned this Dec 5, 2023
@jortel jortel mentioned this issue Dec 5, 2023
Merged
jortel added a commit that referenced this issue Dec 5, 2023
@jortel
🐛 TechDependencies deduplicated with direct taking priority. (#573)
82174a2 
TechDependencies deduplicated with direct taking priority.
The solution is to sort the dependencies with DIRECT first. Then relax
the Create() to ignore dups on conflict.
The dependencies are not a memory concern.

fixes: #572

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jortel jortel

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 TechDependencies deduplicated with direct taking priority. jortel/tackle2-hub
1 participant
@jortel