✨ Support multi-container Providers. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jortel
commented
May 30, 2024
| @@ -59,6 +59,9 @@ func (b *Deps) read() (input []output.DepsFlatItem, err error) { | |||
| input = []output.DepsFlatItem{} | |||
| f, err := os.Open(b.Path) | |||
| if err != nil { | |||
| if os.IsNotExist(err) { | |||
There was a problem hiding this comment.
hint: some providers do not report deps.
jortel
commented
May 30, 2024
cmd/analyzer.go
Outdated
| @@ -17,7 +17,7 @@ type Analyzer struct { | |||
| // Run analyzer. | |||
| func (r *Analyzer) Run() (b *builder.Issues, err error) { | |||
| output := path.Join(Dir, "report.yaml") | |||
| cmd := command.New("/usr/bin/konveyor-analyzer") | |||
| cmd := command.New("/usr/local/bin/konveyor-analyzer") | |||
There was a problem hiding this comment.
hint: compat with latest analyzer.
jortel
commented
May 30, 2024
| if err != nil { | ||
| return | ||
| } | ||
| addon.Attach(f) |
There was a problem hiding this comment.
hint: Attach settings for cleaner activity log.
jortel
commented
May 30, 2024
| return | ||
| } | ||
|
|
||
| // AppendExtensions adds extension fragments. |
There was a problem hiding this comment.
hint: main magic here for aggregating the provider init configs.
jortel
commented
May 30, 2024
| p.Proxy = &provider.Proxy{ | ||
| HTTPProxy: http, | ||
| HTTPSProxy: https, | ||
| NoProxy: strings.Join( |
There was a problem hiding this comment.
hint: newer method for passing proxies to providers.
jortel
commented
May 30, 2024
| namespace: konveyor-tackle | ||
| name: analyzer | ||
| spec: | ||
| priority: 10 |
There was a problem hiding this comment.
hint: The default priority is 0. priority 10 here assumes discovery (and other system initiated) tasks will be 0 and all user initiated tasks would be 10 leaving a little room for priorities in between.
mansam
approved these changes
May 31, 2024
Signed-off-by: Jeff Ortel <jortel@redhat.com>
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: konveyor/tackle2-hub#599