Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for verbosity. #68

Merged
merged 5 commits into from
Dec 19, 2023
Merged

✨ Add support for verbosity. #68

merged 5 commits into from
Dec 19, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Dec 7, 2023

Add support for verbosity. This mainly applies to reporting in task activity.

When requested, the command output is included (live) in the activity log. This provides more detail and better insight into what the command is doing currently.

Requires:

closes #61

Copy link
Contributor

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the replace

go.mod Outdated
@@ -14,6 +14,8 @@ require (
k8s.io/utils v0.0.0-20220728103510-ee6ede2d64ed
)

replace github.com/konveyor/tackle2-addon => github.com/jortel/tackle2-addon v0.0.0-20231208142659-c1c71f08ffcd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentional/just for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for testing. Will fix with command after konveyor/tackle2-addon#49 is merged.

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel requested a review from mansam December 18, 2023 16:46
Copy link
Contributor

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis logs should be available for debugging
3 participants