✨ Support new dropdown for language select #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ibolton336 , these changes look good. As a rule, PRs are merged after a successful Jenkins run. Since, PR 1951 has not been merged yet, could you please attach a screenshot of the results of the local run of this PR on analysis/source_analysis.test.ts tests with the changes from PR 1951 ? I'm available on Slack if you need something from me. |
|
I checked tackle2-ui-ci-run-PR1951 that shows that 1) the analysis/source_analysis_without_creds .test.ts file(tier0 test) was run through 'global-ci-job' and 2) that the test passed. |
abrugaro
reviewed
Jun 18, 2024
Signed-off-by: Ian Bolton <ibolton@redhat.com>
ibolton336
force-pushed
the
fix-select-language
branch
from
8913a27
to
c971d4c
Compare
abrugaro
approved these changes
Jun 20, 2024
ibolton336
added a commit
to konveyor/tackle2-ui
that referenced
this pull request
Jun 20, 2024
Resolves #1950 UI Tests PR: 1136 Needs: konveyor/tackle-ui-tests#1136 Includes: - Provide a "(Show All)" option to display all targets regardless of language tags. Adds a new component to handle this new menu type. - Populate the options list from the Provider field of the fetched targets. - Initially select the languages based on the tags, of tag category "Language", across the applications selected for analysis. - Update TS type for Target to reflect the provider type changing to a string[]. - Covers the hub change to the task model described here: >The application Analysis fields used to correlated to task by addon. This needs to be updated to correlate by kind == "analyzer" (when not blank) else fallback on addon == "analyzer". The fallback is needed to correlate tasks created in previous releases. - Each target card should always display a label with it's provider. This will allow cards that belong to different providers to be differentiated when more than one language is selected. <img width="1360" alt="Screenshot 2024-06-12 at 3 37 47 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/085de6c1-3b56-4532-ab38-81732da377e6"> --------- Signed-off-by: Ian Bolton <ibolton@redhat.com> Co-authored-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
sjd78
added a commit
to sjd78/tackle-ui-tests
that referenced
this pull request
Jun 28, 2024
Follow-up to konveyor#1136 To make sure the test does not unselected the desired target language that is automatically selected from the application's tags (language-discovery automatically adds tags when the application is created), switch from a `click` action to a `check` action. A bit more code is used to get to the input checkbox so the `check()` will work. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
added a commit
to sjd78/tackle-ui-tests
that referenced
this pull request
Jun 28, 2024
Follow-up to konveyor#1136 To make sure the test does not unselected the desired target language that is automatically selected from the application's tags (language-discovery automatically adds tags when the application is created), switch from a `click` action to a `check` action. A bit more code is used to get to the input checkbox so the `check()` will work. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
added a commit
to sjd78/tackle-ui-tests
that referenced
this pull request
Jun 28, 2024
Follow-up to konveyor#1136 To make sure the test does not unselected the desired target language that is automatically selected from the application's tags (language-discovery automatically adds tags when the application is created), switch from a `click` action to a `check` action. A bit more code is used to get to the input checkbox so the `check()` will work. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sshveta
pushed a commit
that referenced
this pull request
Jun 28, 2024
* [RFR] Fix selecting language on analysis wizard, targets step Follow-up to #1136 To make sure the test does not unselected the desired target language that is automatically selected from the application's tags (language-discovery automatically adds tags when the application is created), switch from a `click` action to a `check` action. A bit more code is used to get to the input checkbox so the `check()` will work. Signed-off-by: Scott J Dickerson <sdickers@redhat.com> * run prettier and have it ignore cypress run files Signed-off-by: Scott J Dickerson <sdickers@redhat.com> --------- Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports konveyor/tackle2-ui#1951