Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 adding ability for the metadata.namespace to be what we watch #277

Merged

Conversation

shawn-hurley
Copy link
Contributor

No description provided.

@shawn-hurley
Copy link
Contributor Author

Will this break any of the CSV generation or something though?

@djzager
Copy link
Member

djzager commented Nov 7, 2023

you need to run make bundle and I need to understand why the "Validate Bundle CSV" check is not failing...

@djzager
Copy link
Member

djzager commented Nov 7, 2023

Turns out the check isn't failing because operator-sdk generate bundle changes the WATCH_NAMESPACE for you. All you need to do is sign your commit.

Signed-off-by: Shawn Hurley <shawn@hurley.page>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants