Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add port forwarding information to main readme #266

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Oct 4, 2023

I had to find this for my local Linux minikube installation here, so it probably makes sense to have it in the main README?

@jmle jmle changed the title Add port forwarding information to main readme 📖 Add port forwarding information to main readme Oct 4, 2023
@jortel
Copy link
Contributor

jortel commented Oct 19, 2023

I'm curious about why this is needed. I run using minikube all of the time and have not had to do this. I just point my browser at the minikube ip to access the UI.

@jmle
Copy link
Contributor Author

jmle commented Oct 20, 2023

@jortel that actually works, I supposed that access to the site was through localhost. I can either close this or add the minikube ip info

@rromannissen
Copy link
Collaborator

I think adding the minikube ip command makes more sense.

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Copy link
Member

@jmontleon jmontleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK / LGTM

@jmontleon
Copy link
Member

Can you resolve the conflicts with this and we'll get it merged. Thank you!

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants