-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update config/
so make bundle
can update bundle/
#216
Conversation
If this ends up being the direction for metadata updates, let's be sure that the info captured in #200 is not lost. |
1c276e3
to
0c18e4f
Compare
config/
so it can generate bundle/
config/
so it can generate bundle/
c61143d
to
2e7c5ee
Compare
config/
so it can generate bundle/
config/
so make bundle
can update bundle/
2e7c5ee
to
a6bb9ba
Compare
rebased with community email update. ready for review: @jwmatthews @jmontleon @djzager |
@jmontleon , I don't see anything immediately concerning with the proposed changes. We should be business as usual downstream after a few initial adjustments to account for some of the things being introduced (Tackle -> Konveyor, RELATED_IMAGE, relatedImages, etc.). In regards to potential downstream headache, I would like @fbladilo to review to ensure I'm not overlooking something he may catch, but I don't think we need to block merging if it's otherwise ready. Thanks! |
@jmontleon @rayfordj |
@kaovilai @jmontleon I'm not sure how operator is being built and published currently but we might want to update the Dockerfile version to match the operator-sdk used to test this (assuming this Dockerfile is being used), right now is v1.22.0 which is quite dated and possibly CVE loaded: https://github.com/konveyor/tackle2-operator/blob/main/Dockerfile At some point , a full operator-sdk re-scaffolding of the repo might be appropiate , last time it was v1.22 . |
6abcf70
to
43313b1
Compare
config/
so make bundle
can update bundle/
config/
so make bundle
can update bundle/
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Following migration guide from v1.22.0 to v1.28.1 https://sdk.operatorframework.io/docs/upgrading-sdk-version/ - v1.23.0 - Upgrade kustomize versions from v3.8.7 to v4.5.5 - In the `molecule/default`, replace `--load_restrictor none .` with `--load-restrictor LoadRestrictionsNone` - v1.24.0 In Ansible & Helm-based operators, if you need to support arm64, add the following `| sed 's/aarch64/arm64/'` on the following line `ARCH := $(shell uname -m | sed 's/x86_64/amd64/')` The resulting line should look like this `ARCH := $(shell uname -m | sed 's/x86_64/amd64/' | sed 's/aarch64/arm64/')` - v1.25.0 Add docker-buildx target - v1.26.0 update ansible operator Makefile’s run target - v1.28.0 Upgrade kubernetes.core collection to v2.4.0 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
43313b1
to
9966346
Compare
config/
so make bundle
can update bundle/
config/
so make bundle
can update bundle/
Let's not wait 10 months again @kaovilai, merged! |
👻 simplified tools/tackle-opdev.sh with
make bundle
🐛
docker-build
,bundle-build
fixes for docker where--arch
is invalid🌱
make deploy-olm
to run local unpublished changes from source installed with a new bundle.bundle/
looks like in the cluster rather than just creating a simple deployment or replacing the deployment image.make podman-build podman-push bundle bundle-build bundle-push
using ttl.sh registry (no auth required)Goal: minimize functional changes and allow for
make bundle
command to work using info fromconfig/
minimal semantic diff when running through https://yamldiff.com/
curl https://github.com/raw/konveyor/tackle2-operator/main/bundle/manifests/konveyor-operator.clusterserviceversion.yaml | yq -P 'sort_keys(..)'
curl https://github.com/raw/kaovilai/tackle2-operator/configmakefile-update/bundle/manifests/konveyor-operator.clusterserviceversion.yaml | yq -P 'sort_keys(..)'
noop
bundle/
changes>+
|+
no longer has+
other
bundle/
changestackle-operator.v99.0.0
-->konveyor-operator.v99.0.0
RELATED_IMAGE_<>
with prefix removed, lowercased:oauth-proxy
previously not in CSV.tackle-addon
-->addon-admin
tackle-addon-windup
-->addon-windup
tackle-pathfinder
-->pathfinder
tackle-keycloak
-->keycloak-sso
tackle-keycloak-init
-->keycloak-init
RELATED_IMAGE_TACKLE_POSTGRES
replacesRELATED_IMAGE_KEYCLOAK_DATABASE
RELATED_IMAGE_PATHFINDER_DATABASE
While this is in draft, you may see some deletions in this PR which are a result of outdated config/ and will be resolved before coming out of draft..
Closes #201
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com