Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Reworking docs to breakout main README.md #254

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

jwmatthews
Copy link
Member

@jwmatthews jwmatthews commented Jul 24, 2024

Broke out README.md and began to expand docs in other areas.

Signed-off-by: John Matthews <jwmatthews@gmail.com>
Signed-off-by: John Matthews <jwmatthews@gmail.com>
Copy link
Contributor

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

- The primary client will be an IDE plugin
- It's also possible to issue API requests directly, and we have a python script that does this to aid demonstrations. See [example/README.md](example/README.md)

## `podman compose up`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to mention here that they can also built the image and specify it by providing the IMAGE (default quay.io/konveyor/kai and TAG envvars (default stable)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 will add

docs/Getting_Started.md Show resolved Hide resolved
docs/Usage.md Outdated

## Usage Overview

The primary way to use Kai is via an IDE Plugin that communicates to the backend RST API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The primary way to use Kai is via an IDE Plugin that communicates to the backend RST API.
The primary way to use Kai is via an IDE Plugin that communicates to the backend REST API.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

docs/Usage.md Outdated

[example/run_demo.py](example/run_demo.py), that will run through a migration of

* We have an example script that shows what usage to API looks like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems out of place/incomplete

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 reworking, had cruft in there

docs/Usage.md Outdated

1. We launch VSCode with our Kai VS Code extension from [konveyor-ecosystem/kai-vscode-plugin](https://github.com/konveyor-ecosystem/kai-vscode-plugin/tree/main)
2. We open a git checkout of a sample application: [coolstore](https://github.com/konveyor-ecosystem/coolstore)
3. We run [Kantra](https://github.com/konveyor/kantra) inside of VSCode to do an analysis of the application to learn what issues are present that need to be addressed before migrating to Quarkus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mention that this is something you can do from the extension

docs/contrib/Demo_Mode.md Show resolved Hide resolved

## Local Development

Running Kai's backend involves running 2 processes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least 2, the hub-importer is an optional 3rd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 adding


Analysis data will be stored in: `samples/analysis_reports/{APP_NAME}/<initial|solved>/output.yaml`

## Building a local image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover or TODO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added more on this

Signed-off-by: John Matthews <jwmatthews@gmail.com>
Signed-off-by: John Matthews <jwmatthews@gmail.com>
@jwmatthews jwmatthews marked this pull request as ready for review July 25, 2024 20:05
@jwmatthews jwmatthews changed the title [WIP] Reworking docs to breakout main README.md :book Reworking docs to breakout main README.md Jul 25, 2024
@jwmatthews jwmatthews changed the title :book Reworking docs to breakout main README.md 📖 Reworking docs to breakout main README.md Jul 25, 2024
Signed-off-by: John Matthews <jwmatthews@gmail.com>
@fabianvf fabianvf merged commit 29f6e2b into konveyor:main Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants