Fixed ExtendedIncident

Signed-off-by: JonahSussman <sussmanjonah@gmail.com>
konveyor · Jul 21, 2024 · 76d8d62 · 76d8d62
1 parent 31418d1
commit 76d8d62
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/kai/models/report_types.py b/kai/models/report_types.py
@@ -49,9 +49,9 @@ class ExtendedIncident(Incident):
     """
 
     ruleset_name: str
-    ruleset_description: Optional[str]
+    ruleset_description: Optional[str] = None
     violation_name: str
-    violation_description: Optional[str]
+    violation_description: Optional[str] = None
 
 
 # Link defines an external hyperlink

diff --git a/tests/test_report.py b/tests/test_report.py
@@ -2,6 +2,7 @@
 import pprint
 import unittest
 
+from kai.models.report_types import ExtendedIncident
 from kai.report import Report
 
 
@@ -36,15 +37,16 @@ def test_impacted_files(self):
         self.assertTrue(test_file_entry in impacted_files)
         test_entry = impacted_files[test_file_entry]
         self.assertTrue(len(test_entry) == 6)
-        self.assertTrue("violation_name" in test_entry[0].keys())
-        self.assertTrue("violation_description" in test_entry[0].keys())
-        self.assertTrue("ruleset_name" in test_entry[0].keys())
-        self.assertTrue("ruleset_description" in test_entry[0].keys())
-        self.assertTrue("message" in test_entry[0].keys())
-        self.assertTrue("variables" in test_entry[0].keys())
-        self.assertTrue("file" in test_entry[0]["variables"].keys())
-        self.assertTrue("kind" in test_entry[0]["variables"].keys())
-        self.assertTrue("name" in test_entry[0]["variables"].keys())
+        self.assertTrue(isinstance(test_entry[0], ExtendedIncident))
+        # self.assertTrue("violation_name" in test_entry[0].keys())
+        # self.assertTrue("violation_description" in test_entry[0].keys())
+        # self.assertTrue("ruleset_name" in test_entry[0].keys())
+        # self.assertTrue("ruleset_description" in test_entry[0].keys())
+        # self.assertTrue("message" in test_entry[0].keys())
+        # self.assertTrue("variables" in test_entry[0].keys())
+        # self.assertTrue("file" in test_entry[0]["variables"].keys())
+        # self.assertTrue("kind" in test_entry[0]["variables"].keys())
+        # self.assertTrue("name" in test_entry[0]["variables"].keys())
 
 
 if __name__ == "__main__":