🐛 Add annotation inspection support #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jmle
commented
Jul 16, 2024
•
jmle
commented
- Adds support for annotation queries, allowing to inspect matched FIELDs, METHOD_DECLARATIONs and TYPE declarations.
- Corrects a bug with parenthesis handling.
- Adds support for METHOD_DECLARATION.
jmle
force-pushed
the
annotation-inspection
branch
from
0434553
to
f10f3fa
Compare
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
jmle
force-pushed
the
annotation-inspection
branch
from
f10f3fa
to
96aece2
Compare
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
| @@ -108,6 +111,28 @@ private static SearchPattern mapLocationToSearchPatternLocation(int location, St | |||
| return getPatternSingleQuery(location, query); | |||
| } | |||
|
|
|||
| /** | |||
...r-bundle.core/src/main/java/io/konveyor/tackle/core/internal/symbol/WithAnnotationQuery.java
Outdated
Show resolved
Hide resolved
pranavgaikwad
requested changes
Jul 16, 2024
...r-bundle.core/src/main/java/io/konveyor/tackle/core/internal/symbol/WithAnnotationQuery.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
pranavgaikwad
approved these changes
Jul 16, 2024
This was referenced Jul 17, 2024
shawn-hurley
pushed a commit
to konveyor/analyzer-lsp
that referenced
this pull request
Jul 22, 2024
This PR adds support for inspecting annotations. :green_circle: Things that can be done now: - Check for annotations that are annotating specific `FIELD_DECLARATION`, `METHOD_DECLARATION` or `TYPE` - Match against `METHOD_DECLARATION` :red_circle: Things that cannot be done **yet**: - Match `location: ANNOTATION` and inspect its values. - Inspect on annotations on `location: CONSTRUCTOR`. Depends on: - konveyor/java-analyzer-bundle#104 Fixes: - #460 - #467 --------- Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
|
Also fixes #36 |
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.