🐛 unable to run binary path with maven output log #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Hurley <shawn@hurley.page>
|
@shawn-hurley Is this something that'd be better to comment out and add a TODO until we understand more of the issue? To unblock using binaryPath for now |
|
I don't think we need this info it's a on of info and we handle the warnings and log when it errors and we fall back. I think I am ok with just removing it. Good thought though just me 2c if you feel strongly I can do it the other way I am not tied to either approach |
|
That makes sense. No strong feelings - LGTM |
eemcmullan
approved these changes
Jul 18, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.