✨ enable taking http proxy settings #230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
proxyConfig
in provider settings. This is so that providers know whether a proxy should be used. This is technically only useful for external providers. Right now, we only have go provider which is basically taking the provider settings and setting proxy config as environment variables becausego
respects standard system settings. Other providers, however, may use these settings differently.java.net.useSystemProxy
is a env var that most Java programs respect, which m2e core doesn't seem to respect. For this case, we need to specify settings viasettings.xml
file. This file is a common practice within users to set proxy settings for maven, we also have support for taking a settings file via Hub. As a result, we are adding aproviderSpecificConfig
field for Java that allows taking this file in addition to the normal proxy settings.NOTE: There is one case which I haven't tested - when an external provider runs outside the network of the main process, and there is a proxy to establish connection between the provider and the rule engine itself. I believe that gRPC client should respect system proxies in that case too and we don't need to do anything special there. I am not sure right now. I am creating an issue just to make sure we don't lose track of that case.