Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for CRAN? #153

Closed
mitch-tanney-coterie opened this issue Aug 15, 2023 · 10 comments
Closed

Plans for CRAN? #153

mitch-tanney-coterie opened this issue Aug 15, 2023 · 10 comments

Comments

@mitch-tanney-coterie
Copy link

First and foremost, thanks for maintaining this package. We use it throughout several modeling pipelines that also leverage the tidymodels framework.

We noticed recently that vip() was removed from CRAN. Is the current status below temporary due to CRAN-imposed requirements, or are you no longer planning to maintain this package?

image

@bgreenwell
Copy link
Member

Well, this is news to me as we had just updated the package a few weeks ago and it was accepted to CRAN. I will look into this shortly, but yes, temporary.

@mitch-tanney-coterie
Copy link
Author

Sounds good, and thanks for the prompt reply.

@mitokic
Copy link

mitokic commented Aug 18, 2023

I'd like to add this package into my R packaged called finnts, looking forward to seeing this get back onto cran soon so I can ship my package update. Thanks team.

@bgreenwell
Copy link
Member

Thanks @mitokic, resubmitting to CRAN as we speak, so hopefully fixed over the weekend!

@bgreenwell
Copy link
Member

Back on CRAN! Will take a day or two for the Max/Windows binaries to appear. Apologies for the mishap! Will leave this open until all the binaries are back up.

@mitokic
Copy link

mitokic commented Aug 21, 2023

Thank you!

@mitch-tanney-coterie
Copy link
Author

Thank you!

Agreed. Thanks for moving quickly on this, @bgreenwell.

@mitokic
Copy link

mitokic commented Aug 21, 2023

@bgreenwell why does the latest package require R 4.1 or greater? Could it technically work with R 3.6? Just curious if it's a limitation on a package dependency or not.

@bgreenwell
Copy link
Member

@mitokic I suppose it’s not a “strong” requirement but I wanted to lose the magrittr dependency and R 4.1 introduced the native pipe operator. I suppose this dependency could be relaxed in the next version if needed?

@mitokic
Copy link

mitokic commented Aug 22, 2023

@bgreenwell no worries I think I can work around it since I'd like to add vip into the suggests portion of my finnts package. Thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants