-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should toml be added as a dependency? #100
Comments
yes, I did miss that. Obviously, if it is used in some part of the code it should be a dependency. Do you want to send in a PR? As for the reason why it didn't fail before: |
Yes. I need per-repo approval to contribute to repos, and blackdoc is not yet on that list. It won't be hard to get but takes a few days — as long as that timing is OK with you |
well, I'd estimate this to be a single line PR so if getting the approval takes more than 5 Minutes it's probably not worth it. Unless you expect to open other PRs? (to be sure, those are always welcome!) |
reopening so I don't forget to update the vendored code |
Hi @keewis !
Our CI is failing with:
And I noticed that toml isn't specified in setup.cfg. Should it be?
Thank you!
The text was updated successfully, but these errors were encountered: