Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore mode fails when switching between modalities #249

Open
LTLA opened this issue Sep 22, 2023 · 0 comments
Open

explore mode fails when switching between modalities #249

LTLA opened this issue Sep 22, 2023 · 0 comments

Comments

@LTLA
Copy link
Collaborator

LTLA commented Sep 22, 2023

If you have a multi-modal analysis

AND you switch between modalities in the UI

AND the row data is different between the modalities,

we see the following bug:

Screenshot 2023-09-22 at 11 20 50 AM

I've traced this to

genesInfo[geneColSel[props?.selectedModality]][
row.gene
]

where it seems that geneColSel[props?.selectedModality] refers to a column of genesInfo that does not yet exist because genesInfo is still pointing to the previous modality's row data while geneColSel[props?.selectedModality] is new.

I think this is because geneColSel remembers its previous selection (which is good), so when you go to a new modality and then go back to the previous modality, it tries to retrieve the previous selection (so far so good) but the genesInfo has not yet updated. I guess there must be some code that defends against this on the first selection of a new modality, but this is skipped when we re-select a modality that we went to before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant