Now we store the metadata in setup.cfg. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreyCat
reviewed
Mar 22, 2018
setup.py
Outdated
| cfg["metadata"]["version"]=__version__ | ||
| #print(cfg) | ||
| cfg["options"].update(cfg["metadata"]) | ||
| cfg=cfg["options"] |
There was a problem hiding this comment.
Please fix this broken formatting. Literally all style checkers (pep8, pycodestyle, pylint) complain about:
C: 6, 0: Exactly one space required around assignment
C: 8, 0: Exactly one space required around assignment
C: 11, 0: Exactly one space required around assignment
Probably optional:
C: 6, 0: Constant name "this_dir" doesn't conform to UPPER_CASE naming style (invalid-name)
C: 7, 0: Constant name "cfg" doesn't conform to UPPER_CASE naming style (invalid-name)
C: 11, 0: Constant name "cfg" doesn't conform to UPPER_CASE naming style (invalid-name)
C: 3, 0: standard import "import os" should be placed before "from setuptools import setup" (wrong-import-order)
GreyCat
reviewed
Mar 22, 2018
setup.cfg
Outdated
| @@ -1,5 +1,39 @@ | |||
| [metadata] | |||
| name = kaitaistruct | |||
| version = 0.1.0 | |||
There was a problem hiding this comment.
Shall we have it here in the first place, given that we override it in the code? If it's mandatory, could we put something clearly invalid (like ??? or xxx or 0.0.0) here?
There was a problem hiding this comment.
Oops, I have forgotten to remove it after I have copied my boilerplate.
|
Thanks for this contribution! Could you fix these style issues, so I can merge it? |
KOLANICH
force-pushed
the
setup.cfg
branch
2 times, most recently
from
25f233c
to
5bdc694
Compare
|
Looks legit! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.