Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DenyPSALabel admission plugin #10950

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

galal-hussein
Copy link
Contributor

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@galal-hussein galal-hussein requested a review from a team as a code owner September 25, 2024 21:01
pkg/admission/denypsalabel/admission.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 3.22581% with 30 lines in your changes missing coverage. Please review.

Project coverage is 43.77%. Comparing base (ed14f7f) to head (369362c).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/admission/denypsalabel/admission.go 0.00% 26 Missing ⚠️
pkg/daemons/control/server.go 0.00% 3 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (ed14f7f) and HEAD (369362c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ed14f7f) HEAD (369362c)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10950      +/-   ##
==========================================
- Coverage   49.64%   43.77%   -5.87%     
==========================================
  Files         178      179       +1     
  Lines       14801    14832      +31     
==========================================
- Hits         7348     6493     -855     
- Misses       6105     7139    +1034     
+ Partials     1348     1200     -148     
Flag Coverage Δ
e2etests 36.15% <3.22%> (-9.82%) ⬇️
inttests 36.67% <3.22%> (+16.95%) ⬆️
unittests 13.52% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
pkg/admission/denypsalabel/admission.go Outdated Show resolved Hide resolved
pkg/admission/denypsalabel/admission.go Outdated Show resolved Hide resolved
pkg/admission/denypsalabel/admission.go Outdated Show resolved Hide resolved
pkg/cli/cmds/server.go Outdated Show resolved Hide resolved
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants