From 8f16abe5cc8121916a10ad0cf1ac256806a06e60 Mon Sep 17 00:00:00 2001
From: Alberto Sartori <alberto.sartori86@gmail.com>
Date: Mon, 25 Feb 2019 12:08:37 +0100
Subject: [PATCH] fix bug in handling dependencies

---
 meson/config/p-ipeps/config.h.in     | 7 +++----
 meson/config/p-ipeps/meson.build     | 2 +-
 meson/dependencies/lbfgs/meson.build | 1 -
 meson/dependencies/meson.build       | 5 -----
 meson/dependencies/rsvd/meson.build  | 6 ++----
 meson_options.txt                    | 2 --
 6 files changed, 6 insertions(+), 17 deletions(-)

diff --git a/meson/config/p-ipeps/config.h.in b/meson/config/p-ipeps/config.h.in
index d84c521..72bff15 100644
--- a/meson/config/p-ipeps/config.h.in
+++ b/meson/config/p-ipeps/config.h.in
@@ -1,11 +1,10 @@
 #ifndef _peps_config_h_meson
 #define _peps_config_h_meson
 
-#mesondefine PEPS_WITH_RSVD
-
-#mesondefine PEPS_WITH_MKL
-
 #mesondefine PEPS_WITH_ARPACK
+#mesondefine PEPS_WITH_LBFGS
+#mesondefine PEPS_WITH_MKL
+#mesondefine PEPS_WITH_RSVD
 
 #mesondefine COMPILER_HAS_DIAGNOSTIC_PRAGMA
 
diff --git a/meson/config/p-ipeps/meson.build b/meson/config/p-ipeps/meson.build
index 08fa6b2..3d0aac6 100644
--- a/meson/config/p-ipeps/meson.build
+++ b/meson/config/p-ipeps/meson.build
@@ -3,7 +3,7 @@ _cdata = configuration_data()
 # optional_deps is defined in meson.build in the dependencies folder
 foreach _opt : optional_deps
     _v = 'PEPS_WITH_'+ _opt.to_upper()
-    _cdata.set(_v, get_variable('with_'+_opt, false))
+    _cdata.set(_v, get_option(_opt))
 endforeach
 
 
diff --git a/meson/dependencies/lbfgs/meson.build b/meson/dependencies/lbfgs/meson.build
index 1aa44af..91f3887 100644
--- a/meson/dependencies/lbfgs/meson.build
+++ b/meson/dependencies/lbfgs/meson.build
@@ -1,4 +1,3 @@
-set_variable('with_lbfgs', true)
 
 include_dirs += _lbfgs_include # defined in the meson.build in the bundled subdir
 #source_files += _lbfgs_source_files # defined in the meson.build in the bundled subdir
diff --git a/meson/dependencies/meson.build b/meson/dependencies/meson.build
index ceb57f3..dce5794 100644
--- a/meson/dependencies/meson.build
+++ b/meson/dependencies/meson.build
@@ -19,11 +19,6 @@ foreach _opt : optional_deps
         # first, we source the subdir where we test we can
         # compile and link and we update the list deps
         subdir(_opt)
-        # everything went fine and we can define a variable
-        # that will be used in the generation of the
-        # config file where we log the features of
-        # our project
-        set_variable('with_'+_opt, true)
     endif
 endforeach
 
diff --git a/meson/dependencies/rsvd/meson.build b/meson/dependencies/rsvd/meson.build
index d1b0596..afbd44a 100644
--- a/meson/dependencies/rsvd/meson.build
+++ b/meson/dependencies/rsvd/meson.build
@@ -1,9 +1,7 @@
 # rsvd requires mkl
-if not get_variable('with_mkl')
-    error('RSVD requires MKL. Please reconfigure by either passing -Dmkl=true or -Dmkl-dir=/path/to/mkl.')
+if not get_option('mkl')
+    error('RSVD requires MKL. Please reconfigure by passing -Dmkl=true  and eventually -Dmkl-dir=/path/to/mkl.')
 endif
 
-set_variable('with_rsvd', true)
-
 include_dirs += _rsvd_include # defined in the meson.build in the bundled subdir
 source_files += _rsvd_source_files # defined in the meson.build in the bundled subdir
diff --git a/meson_options.txt b/meson_options.txt
index d13919a..45c578a 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,7 +1,5 @@
 option('build-examples', type: 'boolean', value: true)
 
-# TODO these should become type feature
-
 ########### external dependendencies:
 # one option with `library_name`, type boolean
 # one option with `library_name-dir`, type string