From 1d1fd82047e17ab2bcaf4d035a19d6ee742131b6 Mon Sep 17 00:00:00 2001 From: "David L. Qiu" Date: Wed, 5 Jul 2023 10:53:04 -0700 Subject: [PATCH] relearn on /ask if embedding model was changed --- .../jupyter-ai/jupyter_ai/chat_handlers/learn.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py b/packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py index 2e8fcdfe2..42f591b27 100644 --- a/packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py +++ b/packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py @@ -252,16 +252,18 @@ def load_metadata(self): j = json.loads(f.read()) self.metadata = IndexMetadata(**j) - def get_relevant_documents(self, question: str) -> List[Document]: - if self.index: - docs = self.index.similarity_search(question) - return docs - return [] + def get_relevant_documents(self, query: str) -> List[Document]: + raise NotImplementedError() async def aget_relevant_documents( self, query: str ) -> Coroutine[Any, Any, List[Document]]: - return self.get_relevant_documents(query) + if not self.index: + return [] + + await self.delete_and_relearn() + docs = self.index.similarity_search(query) + return docs def get_embedding_provider(self): em_provider_cls = self.config_manager.get_em_provider()