Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on backport package async_generator for python >= 3.7 #153

Closed
mkoeppe opened this issue Aug 12, 2021 · 3 comments · Fixed by #154
Closed

Don't rely on backport package async_generator for python >= 3.7 #153

mkoeppe opened this issue Aug 12, 2021 · 3 comments · Fixed by #154

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2021

No description provided.

@davidbrochart
Copy link
Member

But we support python>=3.6.1.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 12, 2021

I'd think backport packages are best used with conditionalizing on the python version as in mkoeppe#1 (untested)

@davidbrochart
Copy link
Member

PR welcome 😄

@mkoeppe mkoeppe mentioned this issue Aug 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use async generator backport only on old python mkoeppe/nbclient
2 participants
@davidbrochart @mkoeppe