Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure with C_AVCODEC but without C_SSHOT doesn't work #1746

Closed
eirnym opened this issue Jul 21, 2020 · 2 comments · Fixed by #5199
Closed

Configure with C_AVCODEC but without C_SSHOT doesn't work #1746

eirnym opened this issue Jul 21, 2020 · 2 comments · Fixed by #5199
Labels
build issues platform: Mac

Comments

@eirnym
Copy link

eirnym commented Jul 21, 2020

Describe the bug
When building with C_AVCODEC set, but with C_SSHOT unset (e.g. missing libpng or we don't want screenshots feature), hardware.cpp will fail on missing type VideoCodec included from "../libs/zmbv/zmbv.h" which is enabled only while screenshot feature is enabled.

To Reproduce
Steps to reproduce the behavior:

  1. uninstall libpng (or reconfigure with --disable-screenshots)
  2. reconfigure
  3. make

Expected behavior
../libs/zmbv/zmbv.h is included with either C_AVCODEC or C_SSHOT is enabled in config.h

Environment (please complete the following information):

  • Tested under macOS/MacPorts
  • DOSBox-X 0.83.3
@Jookia
Copy link
Contributor

Jookia commented Sep 7, 2022

Is this still an issue? It looks fixed in 107a7e7

@eirnym
Copy link
Author

eirnym commented Sep 9, 2022

yep, it looks like so, thank you

@Allofich Allofich mentioned this issue Sep 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build issues platform: Mac
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up warnings and resolved issues Allofich/dosbox-x
3 participants
@Jookia @eirnym @Wengier