-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change of Parameter Range #3025
Comments
Or even easier, edit the config file directly. I understand that the limitation is annoying for you, but it is there as a guidance for less experienced users. |
Well that would have been a way faster way. Next time I will do that. :)
It is not my main problem. I just thought it would be the main cause of the false post-processing. I waited for it to go up to 0.5+ and that happened to day, but it is still the same issue: As you can see, it calculates a wrong value in post-processing. It needs to be corrected to 299, because the first digit is already fully turned (turning cycle between 0.5-0.6). An now I don't know what setting to set. Found someone with a similar issue Config:
|
Once you have edited the edit-config.html, you don't need to change anything in the config.ini |
It is not sufficient to change limits in HTML part only because it's limited in firmware as well. AI-on-the-edge-device/code/components/jomjol_flowcontroll/ClassFlowCNNGeneral.cpp Line 251 in 8481cc4
I did some tests with this part of logic in this branch: @haverland: This could be evaluated further and possibly added to firmware. While the lenghty discussion with rainman I added some test cases in the branch mentioned above. Maybe you can have a look to it. |
Looks good. All tests are fine. I found no uncommented test cases. So I think it should be ok. But I don't understand what it means when analogDigitalTransitionStart can take any value between 0 and 10. |
To be on the safer side I'd suggest to release only from 3-10. This is how the branch is prepared. I assume most meter should be covered with this range. BTW: Unfortunately the parameter name is a bit misleading, because actually it is and was already programmed differently (Not the start of transition is relevant (like the name suggests), but when last digit reaches uncertainty region > x.8). Therefore in my opinion at least the documentation should be adpated as well. |
Any suggestion for another name. Technically its correct, because we need to know the start of the transition phase of the digit. |
That's a good question :-) Maybe more generic "Analog Digit Sync Value".
This is what I also thought but as far I can see it's seems not coded like this, because the respective part of code is only active whenever the digit reaches >=x.8 due to the Code in actual develop: AI-on-the-edge-device/code/components/jomjol_flowcontroll/ClassFlowCNNGeneral.cpp Line 251 in 32282ec
|
"Analog Digit Sync Value" is good. Alternatively "Analog Digit Shift" ? Yes the code should not work, but it did in the test cases. I will have a deeper look on it next days. |
The Feature
In an earlier version, there was no limit for the value entered in the “Analog/Digital Transition Start” item.
Now I have tweaked the configuration again. But now I have the problem, that I can no longer enter the correct value for me, because the allowed limit is between 6.0-9.9.
For me, however, it is now the case that the first digit before the decimal point starts to rotate at 0.50 and finishes rotating at 0.59/0.60.
That's why from 0.6+ I get one m^3 too much and later a negative value.
The text was updated successfully, but these errors were encountered: