Rolling - Test New Update Mechanism #1068
Comments
|
I got Guru Meditations on using the auto build update.zip! Maybe it is not structured according to the firmware needs? |
|
Following steps:
|
|
I think on point 2 @jomjol wanted to write
|
|
A bit confused now. update_rolling looks like I will use it to upload the "update.zip" from the same folder (/dist). |
|
right. I think the firmware.bin also must be moved to the subfolder |
|
Updating the firmware always triggers a Guru Meditation: @JoMol It looks suspicious that it tries to open a folder ( With the |
|
It looks to me as if the bin upload does not run at all, instead it tries to open a non existing file for reading ( |
|
I stuck earlier. The upload size is limited to 2mb (used last rolling action artifacts) upload_post_handler |
|
The Guru Meditation happens in https://github.com/jomjol/AI-on-the-edge-device/blob/rolling/code/components/jomjol_fileserver_ota/server_ota.cpp#L102, when the file does not exist (because the upload did not happen for some reason) |
|
After I fixed the file read open on non existing file (see #1073), I also run into the file size limit: |
|
I've changed the file size to 4MB (server_file_cpp#L
You to fast for me :-) |
|
😄 @jomjol changed the 2MB to 8MB 4 days ago on javascript side: Maybe he missed to update |
|
I also changed it: efb35b1 |
|
If I now upload a |
|
Now, if the zip file already exists, it throws a "server closed" error. if the file does not exist, it uploads it but then whows 😒 |
|
@caco3 The status line is very inconspicuous. I only saw it after reading the code for it. |
Do you mean it in a positive or negative way? |
It's not to small but not on the eye. Right of the Button? I'm not a designer. |
|
I made it just for us so we see the version on a screenshot. if people want to see it, they can check the info page 😄 |
|
Back to the uploading. |
|
Fix is now part of #1074
|
|
You are right - I missed to sync the download size. |
|
With Firefox the release can be updated https://github.com/haverland/AI-on-the-edge-device/releases/tag/v11.4.4 But not every time. If the upload stops early with "File reception failed!" (received == 0 in this case), it didn't stops the update. |
|
I now did following:
After the restart the UI was broken! @jomjol despite the crash, would it be possible to start this task on startup if one of the html files is missing? |
|
After I tried another update with Log: |
|
Additionally, on the sd-card in the folder |
|
And on an upload, if the zip file already exists on the device, the upload gets skipped and the update then fails with "server closed abruptly". Log: So we should delete an already existing (or any) zip beforehand! |
|
The file is delete before the upload is done. BUT: I found a limit of the max length of the delete filename which is 30 characters, including path! I increased this now to 100 characters. |
Can you also add a filename length check at the start of the upload? |
|
I suggest javascript as the firmware is getting crowed. Who can do this? |
|
OK, Safari will not work with uploading. Should we add to Releasenotes. |
OK, I'm on it. |
|
I see your PR. Therefore I would suggest to extend the length to 100 bytes. Of course, unless there is a negative impact I can't see! |
I think the 100 characters will be needed for the complete path including directories. Could we make the filename shorter? |
|
Could anyone test the update scenario described in the test release https://github.com/haverland/AI-on-the-edge-device/releases/tag/v11.4.5 Should we add anything else to the release notes? |
|
is it worth it to add such a tight restrictions? I would expect it saves us a but of RAM (string lengths), but we are at 20% during idle. |
I've read the https://github.com/jomjol/AI-on-the-edge-device/blob/rolling/code/components/jomjol_fileserver_ota/server_ota.cpp#L322 again. It only used for the requested variable and will added to a string variable. So I changed max filename size to 100 in javascript check. |
|
Desciption looks good! What do we need to test before the we release? |
|
I will also test this evening. I suggest to use |
|
One update request for the description: even if you update from a current rolling you should:
Why? The limit of the max filename (~4 MB) and the limit in the filelength description is not covered by the older firmware and html versions. |
1.) I tested from 11.3.1 like described in the release notes. With Firefox it is stable, Safari not, Chrome with warnings Currently no idea what else. |
|
Then I suggest to go to version 12.0.0 towards the weekend - makes it easier to react in case of problems. Usually I give a new main version a new overall name - here it would be "Improve User Experience"? |
I will add a note to current rolling > v11.3.1, but it can be used the same procedure as from 11.3.1. Where is no firmware.zip in release artifacts and html-from-11.3.1.zip is shorter than 30 characters. So we should be safe from almost all rollings > 11.3.1 |
I'm with you with the major release. It breaks previous compatibility. This weekend I can not help, but unit Friday by release creation. Without spaces in tag it will be only one - Release process: |
I don't see the point of a release name, as a mater of fact, I was always confused what you wanted to say with that name :)
I don't think that is needed, I always added version information to the files and it worked without issues. |
What is the limit on the new version? |
|
I also added some changes suggestions to the changelog: #1098 Why do we need to warn about not doing a reboot after flashing? I just tested it (coming from |
Because we changed many html files. I haven't tested all variations. So it's easier and safer. |
|
The release name gives an Dummy like me always a bit of a forecast what will be in the new release, like a weather forecast on TV... the next week will be sunny.... it was in this project always a nice personal spleen from @jomjol and I don´t want to miss it :o) |
Understood - but: some people will update from rather old versions. And they cannot handle file names > 30 characters. They might fail if not renaming before upload. |
If I remember right: 8MB |
I would say we clearly need to write that the first should update to 11.3.1 (as already noted in #1098) . |
|
I did now many updates and never had an issue, well done @jomjol @haverland ! I reworked the OTA page, see #1099 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@haverland @caco3
Did you test the new update mechanism?
I had some strange behaviours, but cannot not reproduce them (no file access, could not read file, ...).
I think it would be time for a new release, but the update mechanism should work :-) .
The text was updated successfully, but these errors were encountered: