Skip to content

Commit

Permalink
elminate tce restart on SubscribeNak
Browse files Browse the repository at this point in the history
When resuming from suspend-to-ram it's likely that UDP SOME-IP works but
the TCP socket got broken. Until a new TCP socket gets established, the
remote end responds SubscribeNak. The handler will call restart()

restart() will early terminate 5 times total. Thereafter it will call
shutdown_and_close_socket_unlocked. This is really expensive if the node
sends thousands of total requests before a TCP socket gets established.

Options include:
1. do not call restart() at all on SubscribeNak. seems safe?
2. fix restart() to early-terminate better in this state, more than 5x
3. ensure that SOMEIP-SD is inhibited in this state (suspend routing?)

This commit implements COVESA#1 but the others might be alternatives
  • Loading branch information
joeyoravec committed May 4, 2024
1 parent 02c199d commit 4f2ed15
Showing 1 changed file with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2510,13 +2510,6 @@ service_discovery_impl::handle_eventgroup_subscription_nack(
_service, _instance, _eventgroup, ANY_EVENT,
PENDING_SUBSCRIPTION_ID); // TODO: This is a dummy call...
}


if (!its_subscription->is_selective()) {
auto its_reliable = its_subscription->get_endpoint(true);
if (its_reliable)
its_reliable->restart();
}
}
}
}
Expand Down

0 comments on commit 4f2ed15

Please sign in to comment.