Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jinahub folder? #66

Open
tadejsv opened this issue Aug 9, 2021 · 4 comments
Open

Rename jinahub folder? #66

tadejsv opened this issue Aug 9, 2021 · 4 comments

Comments

@tadejsv
Copy link
Contributor

tadejsv commented Aug 9, 2021

Since we are only have all the executors here as a convenience for us, shouldn't we rename the folder from jinahub to something else? Seems this way people might confuse this repo with the actual hub.

@mapleeit
Copy link
Member

Agree. And does jinahub/__init__.py have actual functions here?

@tadejsv
Copy link
Contributor Author

tadejsv commented Aug 11, 2021

No, afaik it's there only for some relative imports, right @cristianmtr ?

@cristianmtr
Copy link
Contributor

Yes, not sure if importing in core relies on the name. Needs to be tested if we rename it

@tadejsv
Copy link
Contributor Author

tadejsv commented Aug 12, 2021

The core importing does not rely on it. It only cares about the name of the file it is importing.
In fact, because core can actually prepend jinahub to a module name if it conflicts with something already imported, I think it is best that we rename it to something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants