Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use const AnalyzerManager version 1.8.3 #479

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Use const AnalyzerManager version 1.8.3 #479

merged 2 commits into from
Jul 10, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jul 8, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.
  • Use AnalyzerManager v1.8.3 (const version per vscode extension version).
    You can still specified a specific version in the config

@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jul 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 8, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jul 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

@hadarshjfrog
Copy link
Collaborator

Ideally I'd like to see an integration test that validates the downloaded version then using releases, and a specific version

@attiasas attiasas merged commit 7ed6334 into jfrog:master Jul 10, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadarshjfrog hadarshjfrog hadarshjfrog approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @hadarshjfrog