From 8b61ec2db506129eaa5723ffc443dee7be8f1ab4 Mon Sep 17 00:00:00 2001 From: Gal Ben Ami Date: Sun, 6 Oct 2024 16:40:49 +0300 Subject: [PATCH] 2673 - Recursively search for .mvn dir (#1273) --- go.mod | 2 +- go.sum | 4 ++-- utils/mvn/utils.go | 9 +++++++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index 7a88aed6f..d7c6570a8 100644 --- a/go.mod +++ b/go.mod @@ -98,6 +98,6 @@ require ( // replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go v1.28.1-0.20240918081224-1c584cc334c7 -// replace github.com/jfrog/build-info-go => github.com/jfrog/build-info-go v1.8.9-0.20240918150101-ad5b10435a12 +replace github.com/jfrog/build-info-go => github.com/galusben/build-info-go v0.0.0-20240930113238-ac3b31030284 // replace github.com/jfrog/gofrog => github.com/jfrog/gofrog v1.3.3-0.20231223133729-ef57bd08cedc diff --git a/go.sum b/go.sum index 05bb6f265..28dfa7abe 100644 --- a/go.sum +++ b/go.sum @@ -60,6 +60,8 @@ github.com/frankban/quicktest v1.14.6 h1:7Xjx+VpznH+oBnejlPUj8oUpdxnVs4f8XU8WnHk github.com/frankban/quicktest v1.14.6/go.mod h1:4ptaffx2x8+WTWXmUCuVU6aPUX1/Mz7zb5vbUoiM6w0= github.com/fsnotify/fsnotify v1.7.0 h1:8JEhPFa5W2WU7YfeZzPNqzMP6Lwt7L2715Ggo0nosvA= github.com/fsnotify/fsnotify v1.7.0/go.mod h1:40Bi/Hjc2AVfZrqy+aj+yEI+/bRxZnMJyTJwOpGvigM= +github.com/galusben/build-info-go v0.0.0-20240930113238-ac3b31030284 h1:HVacW9zPE/vtED3o1vh0hObeA14FTWWi7uta1+uBTZo= +github.com/galusben/build-info-go v0.0.0-20240930113238-ac3b31030284/go.mod h1:JcISnovFXKx3wWf3p1fcMmlPdt6adxScXvoJN4WXqIE= github.com/gliderlabs/ssh v0.3.7 h1:iV3Bqi942d9huXnzEF2Mt+CY9gLu8DNM4Obd+8bODRE= github.com/gliderlabs/ssh v0.3.7/go.mod h1:zpHEXBstFnQYtGnB8k8kQLol82umzn/2/snG7alWVD8= github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 h1:+zs/tPmkDkHx3U66DAb0lQFJrpS6731Oaa12ikc+DiI= @@ -92,8 +94,6 @@ github.com/jedib0t/go-pretty/v6 v6.5.9 h1:ACteMBRrrmm1gMsXe9PSTOClQ63IXDUt03H5U+ github.com/jedib0t/go-pretty/v6 v6.5.9/go.mod h1:zbn98qrYlh95FIhwwsbIip0LYpwSG8SUOScs+v9/t0E= github.com/jfrog/archiver/v3 v3.6.1 h1:LOxnkw9pOn45DzCbZNFV6K0+6dCsQ0L8mR3ZcujO5eI= github.com/jfrog/archiver/v3 v3.6.1/go.mod h1:VgR+3WZS4N+i9FaDwLZbq+jeU4B4zctXL+gL4EMzfLw= -github.com/jfrog/build-info-go v1.10.2 h1:RCCBsahRNYOm3W7Z9tAL/ixBLzrOzm4mTgI2N6jvqsw= -github.com/jfrog/build-info-go v1.10.2/go.mod h1:JcISnovFXKx3wWf3p1fcMmlPdt6adxScXvoJN4WXqIE= github.com/jfrog/gofrog v1.7.6 h1:QmfAiRzVyaI7JYGsB7cxfAJePAZTzFz0gRWZSE27c6s= github.com/jfrog/gofrog v1.7.6/go.mod h1:ntr1txqNOZtHplmaNd7rS4f8jpA5Apx8em70oYEe7+4= github.com/jfrog/jfrog-client-go v1.47.1 h1:VT2v28/usTSP56+i3MC3fgRvZoh6vjRgQgs8xTk+sYU= diff --git a/utils/mvn/utils.go b/utils/mvn/utils.go index 89640d45c..876344e17 100644 --- a/utils/mvn/utils.go +++ b/utils/mvn/utils.go @@ -14,6 +14,7 @@ import ( "github.com/jfrog/jfrog-cli-core/v2/utils/config" "github.com/jfrog/jfrog-cli-core/v2/utils/dependencies" "github.com/jfrog/jfrog-client-go/utils/errorutils" + "github.com/jfrog/jfrog-client-go/utils/io/fileutils" "github.com/spf13/viper" ) @@ -102,6 +103,13 @@ func RunMvn(mu *MvnUtils) error { if v, ok := props["buildInfoConfig.artifactoryResolutionEnabled"]; ok { mvnOpts = append(mvnOpts, "-DbuildInfoConfig.artifactoryResolutionEnabled="+v) } + projectRoot, exists, err := fileutils.FindUpstream(".mvn", fileutils.Dir) + if err != nil { + return errorutils.CheckError(err) + } + if !exists { + projectRoot = "" + } dependencyLocalPath, err := getMavenDependencyLocalPath() if err != nil { return err @@ -114,6 +122,7 @@ func RunMvn(mu *MvnUtils) error { useWrapper). SetOutputWriter(mu.outputWriter) mavenModule.SetMavenOpts(mvnOpts...) + mavenModule.SetRootProjectDir(projectRoot) if err = coreutils.ConvertExitCodeError(mavenModule.CalcDependencies()); err != nil { return err }