Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jest-mock)!: remove MockFunctionMetadataType, MockFunctionMetadata and SpyInstance types #14621

Merged
merged 5 commits into from
Nov 1, 2023
Merged

refactor(jest-mock)!: remove MockFunctionMetadataType, MockFunctionMetadata and SpyInstance types #14621

merged 5 commits into from
Nov 1, 2023

Conversation

mrazauskas
Copy link
Contributor

Summary

Time to remove MockFunctionMetadataType, MockFunctionMetadata and SpyInstance types. Instead MockMetadataType, MockMetadata and Spied should be used.

Those were marked as to be removed in Jest 30.

Test plan

Green CI.

@netlify
Copy link

netlify bot commented Oct 15, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ad166f1
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/654263d8bd336e000811366f
😎 Deploy Preview https://deploy-preview-14621--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mrazauskas mrazauskas added this to the Jest 30 milestone Nov 1, 2023
@mrazauskas
Copy link
Contributor Author

@SimenB Friendly ping. This should be ready to land, or? (;

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit 728f112 into jestjs:main Nov 1, 2023
8 of 9 checks passed
@mrazauskas mrazauskas deleted the refactor-remove-mock-types branch November 1, 2023 18:19
@SimenB
Copy link
Member

SimenB commented Nov 16, 2023

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants