From 74ae342b28de957c0d3cf42545cfcf17bd172e4f Mon Sep 17 00:00:00 2001 From: Mukul Ashwath Ram Date: Sun, 3 Feb 2019 12:51:59 -0500 Subject: [PATCH] Addressing malfunctioning code snippet. (#7789) --- docs/Puppeteer.md | 4 ++-- website/versioned_docs/version-22.x/Puppeteer.md | 3 +-- website/versioned_docs/version-23.x/Puppeteer.md | 4 ++-- website/versioned_docs/version-24.0/Puppeteer.md | 4 ++-- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/docs/Puppeteer.md b/docs/Puppeteer.md index 1299bb346870..3ae544e56e97 100644 --- a/docs/Puppeteer.md +++ b/docs/Puppeteer.md @@ -31,8 +31,8 @@ describe('Google', () => { await page.goto('https://google.com'); }); - it('should display "google" text on page', async () => { - await expect(page).toMatch('google'); + it('should be titled "Google"', async () => { + await expect(page.title()).resolves.toMatch('Google'); }); }); ``` diff --git a/website/versioned_docs/version-22.x/Puppeteer.md b/website/versioned_docs/version-22.x/Puppeteer.md index a38fed515128..8e51d6fac78c 100644 --- a/website/versioned_docs/version-22.x/Puppeteer.md +++ b/website/versioned_docs/version-22.x/Puppeteer.md @@ -89,8 +89,7 @@ describe( }, timeout); it('should load without error', async () => { - const text = await page.evaluate(() => document.body.textContent); - expect(text).toContain('google'); + await expect(page.title()).resolves.toMatch('Google'); }); }, timeout, diff --git a/website/versioned_docs/version-23.x/Puppeteer.md b/website/versioned_docs/version-23.x/Puppeteer.md index 3a9e51d4c8da..4b084b9b6f82 100644 --- a/website/versioned_docs/version-23.x/Puppeteer.md +++ b/website/versioned_docs/version-23.x/Puppeteer.md @@ -32,8 +32,8 @@ describe('Google', () => { await page.goto('https://google.com'); }); - it('should display "google" text on page', async () => { - await expect(page).toMatch('google'); + it('should be titled "Google"', async () => { + await expect(page.title()).resolves.toMatch('Google'); }); }); ``` diff --git a/website/versioned_docs/version-24.0/Puppeteer.md b/website/versioned_docs/version-24.0/Puppeteer.md index aad7dd28c867..5262e4b2b29c 100644 --- a/website/versioned_docs/version-24.0/Puppeteer.md +++ b/website/versioned_docs/version-24.0/Puppeteer.md @@ -32,8 +32,8 @@ describe('Google', () => { await page.goto('https://google.com'); }); - it('should display "google" text on page', async () => { - await expect(page).toMatch('google'); + it('should be titled "Google"', async () => { + await expect(page.title()).resolves.toMatch('Google'); }); }); ```