[JENKINS-73164] Fix record issues step ignores source code retention parameter #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correctly handle the sourceCodeRetention parameter
The test ensures that the plugin adheres to the retention policy and properly cleans up files after the build
uhafner
requested changes
Aug 14, 2024
plugin/src/test/java/io/jenkins/plugins/analysis/warnings/steps/StepsOnAgentITest.java
Outdated
Show resolved
Hide resolved
plugin/src/test/java/io/jenkins/plugins/analysis/warnings/steps/StepsOnAgentITest.java
Show resolved
Hide resolved
plugin/src/test/java/io/jenkins/plugins/analysis/warnings/steps/StepsOnAgentITest.java
Outdated
Show resolved
Hide resolved
…s/StepsOnAgentITest.java fixed comment typo Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
…s/StepsOnAgentITest.java deleted Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
============================================
+ Coverage 82.55% 82.65% +0.09%
- Complexity 1352 1355 +3
============================================
Files 248 248
Lines 5212 5213 +1
Branches 401 401
============================================
+ Hits 4303 4309 +6
+ Misses 801 796 -5
Partials 108 108 ☔ View full report in Codecov by Sentry. |
uhafner
requested changes
Aug 15, 2024
Comment on lines
80
to
84
| final FilePath workspace, final Set<String> sourceDirectories, | ||
| final SourceCodeRetention sourceCodeRetention, final Run<?, ?> run, | ||
| final FilePath jenkinsRootDir, final TaskListener listener, | ||
| final String scm, final BlameMode blameMode, final PostProcessingMode postProcessingMode, | ||
| final boolean quiet) { |
| @@ -139,8 +129,7 @@ private AnnotatedReport postProcessReport(final Report report) throws IOExceptio | |||
| AnnotatedReport result = workspace.act(createPostProcessor(report)); | |||
| copyAffectedFiles(result.getReport(), createAffectedFilesFolder(result.getReport())); | |||
| return result; | |||
| } | |||
| else { | |||
| } else { | |||
| @@ -164,8 +153,7 @@ private Blamer createBlamer(final Report report) { | |||
| if (blameMode == BlameMode.DISABLED) { | |||
| report.logInfo("Skipping SCM blames as requested"); | |||
| return new NullBlamer(); | |||
| } | |||
| else { | |||
| } else { | |||
plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/IssuesScanner.java
Outdated
Show resolved
Hide resolved
| @@ -346,8 +331,7 @@ private void resolvePackageNames(final Report report) { | |||
| try { | |||
| PackageNameResolver resolver = new PackageNameResolver(); | |||
| resolver.run(report, getCharset()); | |||
| } | |||
| catch (InvalidPathException exception) { | |||
| } catch (InvalidPathException exception) { | |||
There was a problem hiding this comment.
It seems you reformatted the whole source with the wrong style
There was a problem hiding this comment.
its the intellij on gitpod who keeps doing it , I disabled the default settings but each time I have the same update of white spaces when I added the else block,
do I update the formatting of else and catch to its original and I commit again ?
There was a problem hiding this comment.
Compare your changes with main and revert everything that is unrelated.
| @@ -90,13 +89,36 @@ void shouldRecordOutputOfParallelSteps() { | |||
| if (JAVA_ID.equals(actions.get(0).getId())) { | |||
| first = actions.get(0); | |||
| second = actions.get(1); | |||
| } | |||
| else { | |||
| } else { | |||
plugin/src/test/java/io/jenkins/plugins/analysis/warnings/steps/StepsOnAgentITest.java
Show resolved
Hide resolved
…suesScanner.java fix code formatting Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
…ceCodeRetention-parameter
uhafner
approved these changes
Aug 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recordIssuesstep to correctly honor thesourceCodeRetentionparameter.Submitter checklist