Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test XML result from computer/api/xml end point #97

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Nov 15, 2022

JENKINS-70074 Test XML result from computer/api/xml end point

An unsuccessful attempt to show the failure reported as JENKINS-70074. It is unclear to me why interactive testing easily duplicated the failure, while this automated test does not show the failure.

Test would not show the expected error on Linux, but did show the expected error on Windows. After applying the fix from #96, the test passed as expected on both Windows and Linux.

I confirmed with JaCoCo coverage reporting that the method modified in #96 is called by this test and was not called by any test before.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

An unsuccessful attempt to show the failure reported as
https://issues.jenkins.io/browse/JENKINS-70074 .  It is unclear to me why
interactive testing easily duplicated the failure, while this automated
test does not show the failure.
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Nov 15, 2022
@MarkEWaite MarkEWaite merged commit 020d274 into jenkinsci:master Nov 15, 2022
@MarkEWaite MarkEWaite deleted the fix-REST-api branch January 9, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant