Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display JVM differences with the user-defined JVM comparison mode #195

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Display JVM differences with the user-defined JVM comparison mode #195

merged 2 commits into from
Nov 8, 2023

Conversation

jonesbusy
Copy link
Contributor

@jonesbusy jonesbusy commented Nov 8, 2023 •
edited by MarkEWaite
Loading

Display JVM differences with the user-defined JVM comparison mode

This is a minor follow-up of #190 that uses configured comparator instead of exact string.

Testing done

hpi run and one automated test for the toHtml method (minimal, just to check the html

Submitter checklist
Beta Give feedback

@jonesbusy jonesbusy requested a review from a team as a code owner November 8, 2023 10:19
MarkEWaite
MarkEWaite approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@MarkEWaite MarkEWaite enabled auto-merge (squash) November 8, 2023 13:06
@MarkEWaite MarkEWaite added the bug Incorrect or flawed behavior label Nov 8, 2023
@MarkEWaite MarkEWaite changed the title Use JVM version comparator on node monitor display view Display JVM version differences based on the user defined JVM comparison mode Nov 8, 2023
@MarkEWaite MarkEWaite changed the title Display JVM version differences based on the user defined JVM comparison mode Display JVM differences based on the user defined JVM comparison mode Nov 8, 2023
@MarkEWaite MarkEWaite changed the title Display JVM differences based on the user defined JVM comparison mode Use the user-defined JVM comparison mode to display JVM differences Nov 8, 2023
@MarkEWaite MarkEWaite changed the title Use the user-defined JVM comparison mode to display JVM differences Display JVM differences with the user-defined JVM comparison mode Nov 8, 2023
@MarkEWaite MarkEWaite merged commit 16457ab into jenkinsci:master Nov 8, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
bug Incorrect or flawed behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonesbusy @MarkEWaite