Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize configuration page in German #186

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Localize configuration page in German #186

merged 2 commits into from
Oct 8, 2023

Conversation

StefanSpieker
Copy link
Contributor

@StefanSpieker StefanSpieker commented Oct 8, 2023 •
edited by MarkEWaite
Loading

Added german localization to config and made two missing properties localizable

Testing done

Tested in german and english with Local plugin:
German:
grafik

English:
grafik

Submitter checklist
Beta Give feedback

@StefanSpieker StefanSpieker requested a review from a team as a code owner October 8, 2023 12:02
@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label Oct 8, 2023
@MarkEWaite MarkEWaite changed the title Added german localization to config Localize configuration page in German Oct 8, 2023
MarkEWaite
MarkEWaite approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. I've switched the character set of the translated files from ISO 8859-1 to UTF-8 and verified that the messages display as expected on my browser.

@MarkEWaite MarkEWaite enabled auto-merge (squash) October 8, 2023 12:51
@MarkEWaite MarkEWaite merged commit 94adca8 into jenkinsci:master Oct 8, 2023
13 of 14 checks passed
@StefanSpieker StefanSpieker deleted the german_message branch October 8, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement Improvement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanSpieker @MarkEWaite