Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate Spotless via Maven property rather than file #142

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

basil
Copy link
Member

@basil basil commented Apr 19, 2023

Many thanks for adopting the standard Spotless configuration, which has enabled me to streamline its activation in plugin parent POM 4.61. It is now possible to delete .mvn_exec_spotless and add <spotless.check.skip>false</spotless.check.skip> instead, which I think makes for a more readable configuration.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite enabled auto-merge (squash) April 19, 2023 18:10
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Apr 19, 2023
@MarkEWaite MarkEWaite merged commit 040a19e into jenkinsci:master Apr 19, 2023
@basil basil deleted the spotless-activation branch April 19, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants