Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68542] [WebSocket] Capture cookie returned by server and reuse for reconnection attempts #539

Merged
merged 2 commits into from
May 23, 2022

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented May 23, 2022

JENKINS-68542

Cherry-picked from cc32c3b (#537)

Remoting 4.13 is the version pinned on Jenkins LTS 2.332 and 2.346

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…se for reconnection attempts

Cherry-picked from cc32c3b
@Vlatombe Vlatombe requested a review from jglick May 23, 2022 12:06
@Vlatombe
Copy link
Member Author

I guess I'll need trusted.ci.jenkins.io (cf #532) for this release.

@jglick
Copy link
Member

jglick commented May 23, 2022

I believe so yes. I do not have access. Maybe @timja does?

@MarkEWaite
Copy link
Contributor

I guess I'll need trusted.ci.jenkins.io (cf #532) for this release.

I thought that the transition to JEP-229 was complete enough on this repository that a new release will be created once the pull request is merged.

The only case that I know for generating the release on trusted.ci.jenkins.io is if we require a signed jar file. Is a signed jar file required with this change?

I have permission to launch releases of remoting on trusted.ci.jenkins.io, if needed.

@Vlatombe
Copy link
Member Author

@MarkEWaite this is a case for a backport on a version predating signature removal and JEP-229 setup.

@MarkEWaite
Copy link
Contributor

@MarkEWaite this is a case for a backport on a version predating signature removal and JEP-229 setup.

Thanks @Vlatombe . I had missed that the destination branch is a backport.

Once it is merged, I believe that I can launch the build of the backport.

@Vlatombe
Copy link
Member Author

Unsure what is going on with the windows build though...

@Vlatombe
Copy link
Member Author

#540

@timja
Copy link
Member

timja commented May 23, 2022

I guess I'll need trusted.ci.jenkins.io (cf #532) for this release.

https://release.ci.jenkins.io ftr, requires VPN access and release team membership.

(I see Mark has volunteered to trigger it, make sure you release the backport and not the master branch)

@Vlatombe Vlatombe added the bug For changelog: Fixes a bug. label May 23, 2022
@Vlatombe Vlatombe merged commit ca3f60f into jenkinsci:stable-4.13.x May 23, 2022
@Vlatombe Vlatombe deleted the JENKINS-68542 branch May 23, 2022 12:59
@Vlatombe
Copy link
Member Author

@MarkEWaite stable-4.13.x is ready for release (4.13.1). Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants