Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-60381] Remove old, deprecated protocols. #359

Merged
merged 1 commit into from
Dec 27, 2019
Merged

[JENKINS-60381] Remove old, deprecated protocols. #359

merged 1 commit into from
Dec 27, 2019

Conversation

jeffret-b
Copy link
Contributor

@jeffret-b jeffret-b requested a review from jvz December 5, 2019 16:54
@jeffret-b jeffret-b mentioned this pull request Dec 5, 2019
Merged
4 tasks
jvz
jvz approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jeffret-b
Copy link
Contributor Author

Try a rebuild.

@jeffret-b jeffret-b closed this Dec 26, 2019
@jeffret-b jeffret-b reopened this Dec 26, 2019
@jeffret-b jeffret-b marked this pull request as ready for review December 26, 2019 21:03
@jeffret-b jeffret-b merged commit ba51cf1 into jenkinsci:master Dec 27, 2019
@jeffret-b jeffret-b added the removed Functionality removed or otherwise cleaned up label Dec 27, 2019
jglick
jglick reviewed Jan 3, 2020
View reviewed changes
docs/protocols.md
@@ -27,77 +27,6 @@ If stronger algorithms are needed (for example, AES with 256-bit keys), the [JCE

Protocol uses non-blocking I/O wherever possible which removes the performance bottleneck of the <code>JNLP3-connect</code> protocol.

## Deprecated protocols
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update docs/remoting-3-compatibility.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick left review comments

@jvz jvz jvz approved these changes

Assignees
No one assigned
Labels
removed Functionality removed or otherwise cleaned up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffret-b @jglick @jvz