Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factory is only added to dropdown list if its portlets are not empty #86

Merged
merged 1 commit into from
May 30, 2021

Conversation

simonsymhoven
Copy link
Member

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@simonsymhoven simonsymhoven added the bug Bugs or performance problems label May 30, 2021
@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #86 (2aa9df0) into master (56b687d) will not change coverage.
The diff coverage is n/a.

❗ Current head 2aa9df0 differs from pull request most recent head 081e73e. Consider uploading reports for the commit 081e73e to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master      #86   +/-   ##
=========================================
  Coverage     79.26%   79.26%           
+ Complexity        9        8    -1     
=========================================
  Files             2        1    -1     
  Lines            82       82           
  Branches          7        7           
=========================================
  Hits             65       65           
  Misses           14       14           
  Partials          3        3           
Impacted Files Coverage Δ
...ins/plugins/monitoring/util/PullRequestFinder.java
...in/java/io/jenkins/plugins/monitoring/Monitor.java 79.26% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b687d...081e73e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant