Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing tests for Monitor.java #17

Merged
merged 1 commit into from
May 4, 2021
Merged

add missing tests for Monitor.java #17

merged 1 commit into from
May 4, 2021

Conversation

simonsymhoven
Copy link
Member

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@simonsymhoven simonsymhoven added the tests Enhancement of tests label May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #17 (0a35267) into master (9d87295) will increase coverage by 44.96%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #17       +/-   ##
=============================================
+ Coverage     48.64%   93.61%   +44.96%     
  Complexity        5        5               
=============================================
  Files             3        2        -1     
  Lines            74       47       -27     
  Branches          4        3        -1     
=============================================
+ Hits             36       44        +8     
+ Misses           36        2       -34     
+ Partials          2        1        -1     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/jenkins/plugins/monitoring/Monitor.java 95.65% <100.00%> (+23.55%) 5.00 <0.00> (+1.00)
...enkins/plugins/monitoring/MonitorUserProperty.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d87295...0a35267. Read the comment docs.

@simonsymhoven simonsymhoven merged commit 69f267e into master May 4, 2021
@simonsymhoven simonsymhoven deleted the test branch May 4, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Enhancement of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant