Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a user property to store configuration per user #14

Merged
merged 1 commit into from
May 3, 2021

Conversation

simonsymhoven
Copy link
Member

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@simonsymhoven simonsymhoven added the internal Internal changes without user or API impact label May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #14 (ea6f773) into master (e789cdf) will decrease coverage by 21.80%.
The diff coverage is 16.66%.

❗ Current head ea6f773 differs from pull request most recent head eea6e5c. Consider uploading reports for the commit eea6e5c to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master      #14       +/-   ##
=============================================
- Coverage     70.45%   48.64%   -21.81%     
- Complexity        4        5        +1     
=============================================
  Files             2        3        +1     
  Lines            44       74       +30     
  Branches          3        4        +1     
=============================================
+ Hits             31       36        +5     
- Misses           11       36       +25     
  Partials          2        2               
Impacted Files Coverage Δ Complexity Δ
...enkins/plugins/monitoring/MonitorUserProperty.java 16.66% <16.66%> (ø) 1.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e789cdf...eea6e5c. Read the comment docs.

@simonsymhoven simonsymhoven merged commit d9005be into master May 3, 2021
@simonsymhoven simonsymhoven deleted the user-property branch May 3, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant