Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codacy issues #131

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix codacy issues #131

merged 1 commit into from
Jul 21, 2021

Conversation

simonsymhoven
Copy link
Member

Fix Codacy issues.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@simonsymhoven simonsymhoven added the internal Internal changes without user or API impact label Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #131 (9d86952) into master (085ca7c) will not change coverage.
The diff coverage is 66.66%.

❗ Current head 9d86952 differs from pull request most recent head 2492218. Consider uploading reports for the commit 2492218 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master     #131   +/-   ##
=========================================
  Coverage     79.03%   79.03%           
  Complexity        5        5           
=========================================
  Files             2        2           
  Lines            62       62           
  Branches         10       10           
=========================================
  Hits             49       49           
  Misses            7        7           
  Partials          6        6           
Impacted Files Coverage Δ
...kins/plugins/monitoring/util/PullRequestUtils.java 60.00% <ø> (ø)
...in/java/io/jenkins/plugins/monitoring/Monitor.java 80.70% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085ca7c...2492218. Read the comment docs.

@simonsymhoven simonsymhoven merged commit 695faeb into master Jul 21, 2021
@simonsymhoven simonsymhoven deleted the codingstyle branch July 21, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant