Mark pipeline waitForBuild step with the downstream build result #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exception during |
|
Re-opening to trigger a new build. |
stuartrowe
force-pushed
the
JENKINS-70983
branch
3 times, most recently
from
1ca3981
to
f01a141
Compare
Update test
stuartrowe
force-pushed
the
JENKINS-70983
branch
from
f01a141
to
a853887
Compare
|
@olamy could you please merge this so it can be released? Thanks! |
jglick
reviewed
May 24, 2023
| "} finally {\n" + | ||
| " echo \"'ds' completed with status ${ds.getResult()}\"\n" + | ||
| "}", true)); | ||
| j.assertLogContains("'ds' completed with status UNSTABLE", j.buildAndAssertStatus(Result.UNSTABLE, us)); |
There was a problem hiding this comment.
This sometimes fails: the message is printed but the upstream build is marked a success. The need for
propagate. If that behavior is intentional, then fixing the test properly would mean deleting the sleep and instead having the downstream build pause until a semaphore is set by test code after the upstream build starts waiting.
6 tasks
CJohanH
pushed a commit
to CJohanH/buildWithEiffel
that referenced
this pull request
Feb 9, 2024
This is a new pipeline step that extends BuildTriggerStep from jenkinsci/pipeline-build-step-plugin#112 in order to add a new build action EiffelActivityDataAction to the downstream build. This build action will supplement Eiffel activity data that will override corresponding data fields in the EiffelActivityTriggeredEvent when the downstream build enters the build queue. Unfortunately, in order to add a new action to triggered builds, the step execution of BuildTriggerStep had to be modified, which meant that a number of project files had to be copied with slight modifications to ensure that there is no interference when running with both jenkinsci/eiffel-broadcaster-plugin and jenkinsci/pipeline-build-step-plugin. Also, to ensure the underlying build trigger functionality inherited by the buildWithEiffel step, a regression test suite has been added, containing all the BuildTriggerStep tests. These tests have been updated to use buildWithEiffel and the suite itself is excluded from normal testing to reduce execution time. Currently, buildWithEiffel step only supports activity name.
magnusbaeck
pushed a commit
to jenkinsci/eiffel-broadcaster-plugin
that referenced
this pull request
Mar 7, 2024
This is a new pipeline step that extends BuildTriggerStep from jenkinsci/pipeline-build-step-plugin#112 in order to add a new build action EiffelActivityDataAction to the downstream build. This build action will supplement Eiffel activity data that will override corresponding data fields in the EiffelActivityTriggeredEvent when the downstream build enters the build queue. Unfortunately, in order to add a new action to triggered builds, the step execution of BuildTriggerStep had to be modified, which meant that a number of project files had to be copied with slight modifications to ensure that there is no interference when running with both jenkinsci/eiffel-broadcaster-plugin and jenkinsci/pipeline-build-step-plugin. Also, to ensure the underlying build trigger functionality inherited by the buildWithEiffel step, a regression test suite has been added, containing all the BuildTriggerStep tests. These tests have been updated to use buildWithEiffel and the suite itself is excluded from normal testing to reduce execution time. Currently, buildWithEiffel step only supports activity name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a WarningAction to the
waitForBuildstep FlowNode when the downstream build isn't successful.Also, log the build result when the downstream run completes.
This is the
waitForBuildstep equivalent of #107.Implements https://issues.jenkins.io/browse/JENKINS-70983