From 4bf9d6895c10f02ee2f015bb117c83115dbaba56 Mon Sep 17 00:00:00 2001
From: Neetigya Poddar <neetigyapoddar1@gmail.com>
Date: Mon, 9 Oct 2023 22:52:04 +0530
Subject: [PATCH] feat:Remove inline javascript code from BuoldTriggerStep

---
 .../steps/build/BuildTriggerStep/config.jelly      | 14 +-------------
 .../support/steps/build/BuildTriggerStep/config.js | 13 +++++++++++++
 2 files changed, 14 insertions(+), 13 deletions(-)
 create mode 100644 src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.js

diff --git a/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly b/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly
index 54c1909f..67475521 100644
--- a/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly
+++ b/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly
@@ -44,19 +44,7 @@ THE SOFTWARE.
     <f:entry field="parameters" title="Parameters">
         <div id="params"/>
         <script>
-            function loadParams() {
-                var div = document.getElementById('params');
-                fetch('${descriptor.descriptorUrl}/parameters?job=' + encodeURIComponent(document.getElementById('${jobFieldId}').value) + '&amp;context=${descriptor.contextEncoded}').then((rsp) => {
-                    rsp.text().then((responseText) => {
-                        if (rsp.ok) {
-                            div.innerHTML = responseText;
-                            Behaviour.applySubtree(div);
-                        } else {
-                            div.innerHTML = "<b>ERROR</b>: Failed to load parameter definitions: " + rsp.statusText;
-                        }
-                    });
-                });
-            }
+            <st:adjunct includes="org.jenkinsci.plugins.workflow.support.steps.build.BuildTriggerStep.config"/>
         </script>
     </f:entry>
 </j:jelly>
diff --git a/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.js b/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.js
new file mode 100644
index 00000000..86df74b4
--- /dev/null
+++ b/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.js
@@ -0,0 +1,13 @@
+function loadParams() {
+    var div = document.getElementById('params');
+    fetch('${descriptor.descriptorUrl}/parameters?job=' + encodeURIComponent(document.getElementById('${jobFieldId}').value) + '&amp;context=${descriptor.contextEncoded}').then((rsp) => {
+        rsp.text().then((responseText) => {
+            if (rsp.ok) {
+                div.innerHTML = responseText;
+                Behaviour.applySubtree(div);
+            } else {
+                div.innerHTML = "<b>ERROR</b>: Failed to load parameter definitions: " + rsp.statusText;
+            }
+        });
+    });
+}
\ No newline at end of file