[JENKINS-73744] Tweaks to Node.js contributing instructions + renovate fix

[scherler]

The PR #9718 introduced suboptimal wording and forgot to update .github/renovate.json originally addressed
JENKINS-73744.

Testing done

Proposed changelog entries

• human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[basil]

In the second portion of this document, there are numerous occurrences of the phrase "adding Node and Yarn to your path" linking to the #running-the-yarn-frontend-build section of the documentation. These phrases are now out-of-date, so I suggest changing them to "optionally adding Node and Yarn to your path".

[scherler]

@basil I changed the wording now as you requested. In hindsight we may have saved numerous interactions (and time) if you would have suggested the wording to use in the first place since you seem to had strong feelings about it. 🤷‍♂️

[scherler]

@timja

Seems we changed at the same time, I do not care about mine but I did changed the original title not yours (at least not knowingly)

[basil]

Start using yarn by enabling Corepack corepack enable

Should there be a preposition before corepack enable?

Start using yarn […]; this will add the yarn binary […].

Why is the reference to Yarn in monospaced text at the beginning of the sentence but not at the end of the sentence?

[scherler]

yarn is a command which is lowercase. ...but please use the suggest function in github

[scherler]

I am not a native speaker and the above is adopted from https://yarnpkg.com/getting-started/install

[basil]

the above is adopted from https://yarnpkg.com/getting-started/install

For reference, the original material reads:

Start by enabling Corepack, if it isn't already; this will add the yarn binary to your PATH:
corepack enable

The original material correctly uses a colon to separate corepack enable from the beginning of the sentence. In contrast, the material in this PR does not separate corepack enable (which functions as a noun) from the sentence in any way:

Start using yarn by enabling Corepack corepack enable

Here Corepack is the object of "enabling", and corepack enable (functioning as a noun) is left dangling.

One way to correctly use corepack enable as a noun in the middle of the sentence would be as an object of the preposition "with" (e.g., "with corepack enable").

[scherler]

Thanks for explaining!

[basil]

Thanks for the PR!