Compatibility for ChainedServletFilter

[basil]

Problem

As of #9672, oic-auth started failing with e.g.

java.lang.NoSuchMethodError: 'void hudson.security.ChainedServletFilter.<init>(javax.servlet.Filter[])'
        at org.jenkinsci.plugins.oic.OicSecurityRealm.createFilter(OicSecurityRealm.java:828)
        at hudson.security.SecurityRealm.createFilter(SecurityRealm.java:626)
        at hudson.security.HudsonFilter.reset(HudsonFilter.java:145)
        at jenkins.model.Jenkins.resetFilter(Jenkins.java:2820)
        at jenkins.model.Jenkins.setSecurityRealm(Jenkins.java:2802)
        at org.jenkinsci.plugins.oic.PluginTest.testLoginWithMissingIdTokenShouldBeRefused(PluginTest.java:911)
        at java.base/java.lang.reflect.Method.invoke(Method.java:569)
        at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:706)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.lang.Thread.run(Thread.java:840)

I verified that Reverse Proxy Authentication is also affected:

java.lang.NoSuchMethodError: 'void hudson.security.ChainedServletFilter.<init>(javax.servlet.Filter[])'
	at org.jenkinsci.plugins.reverse_proxy_auth.ReverseProxySecurityRealm.createFilter(ReverseProxySecurityRealm.java:579)
	at hudson.security.SecurityRealm.createFilter(SecurityRealm.java:626)
	at hudson.security.HudsonFilter.reset(HudsonFilter.java:145)
	at jenkins.model.Jenkins.resetFilter(Jenkins.java:2820)
	at jenkins.model.Jenkins.setSecurityRealm(Jenkins.java:2802)
	at org.jenkinsci.plugins.reverse_proxy_auth.ReverseProxySecurityRealmTest.basicAuthenticate(ReverseProxySecurityRealmTest.java:52)

Evaluation

ChainedServletFilter broke binary compatibility.

Solution

Restore the original ChainedServletFilter (perfectly binary compatible) and add a new ChainedServletFilter2 for Jakarta.

Testing done

• CI build of this repository
• PCT: Add OpenId Connect Authentication and Reverse Proxy Authentication to the managed set bom#3544 (reproduced issue before this PR, fixed after this PR). build-user-vars will need to be recompiled after this PR to pass PCT again, but I can take care of that easily once this is released.
• ATH: Add oic auth e2e acceptance-test-harness#1701 (reproduced issue before this PR, fixed after this PR)

I also tested reverse-proxy-auth-plugin in PCT with 2.475, saw the failure mentioned above, and confirmed it was fixed with this PR. I will add reverse-proxy-auth to jenkinsci/bom once I finish adding oic-auth.

Proposed changelog entries

Restore compatibility with the OpenId Connect Authentication and Reverse Proxy Authentication plugins (regression in 2.475).

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Fixes jenkinsci/oic-auth-plugin#387

[basil]

Thanks for the reviews, everyone! With Tuesday's release coming up in a few days and given the impact this regression has had on three plugins, I am going to start the countdown timer now with the intention to merge on Monday if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!