Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb title in DirectoryBrowserSupport #9099

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

daniel-beck
Copy link
Member

DirectoryBrowserSupport doesn't always show workspaces.

https://ci.jenkins.io/userContent/ is not a workspace.
https://ci.jenkins.io/job/Reporting/job/deprecated-usage-in-plugins/lastSuccessfulBuild/artifact/ is not a workspace.

Amends #7496.

Testing done

Went to archived artifacts and user content and confirmed that the same text as in the title was shown.

Proposed changelog entries

too minor

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Mar 28, 2024
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 29, 2024
@MarkEWaite MarkEWaite merged commit c8ee9ea into jenkinsci:master Mar 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants