Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apparently unused Computer/custom-jnlp.jelly #7172

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 27, 2022

3eedda8 just said

TODO: work from home for the rest

Hmm. And then the link was deleted the next day in 10d9ca4, but not the file it linked to.

I can guess at what this was originally supposed to be—a place to edit JNLPLauncher.vmargs—but this was deleted in #6543 anyway.

Proposed changelog entries

  • N/A

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Sep 27, 2022
@NotMyFault
Copy link
Member

At least, no usage in jenkins plugins hosted in this org.

@NotMyFault NotMyFault requested a review from a team September 28, 2022 08:20
@NotMyFault
Copy link
Member

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@NotMyFault NotMyFault added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 28, 2022
@timja timja merged commit 5e30d1f into jenkinsci:master Oct 3, 2022
@jglick jglick deleted the custom-jnlp.jelly branch October 3, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants